This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Improve DBCreator (#66, #84, #109) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as connect, close; update uses; set up default append tables
ssciolla
added
🐛 bug
ssciolla
commented
Apr 22, 2020
This was
linked to
issues
Apr 22, 2020
lsloan
reviewed
Apr 27, 2020
lsloan
approved these changes
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to
DBCreator, and usages, to resolve a few issues that have accumulated related to the class. The issues and how they were resolved are described below in the task list. The PR aims to resolve issues #66, #84, and #109.DEFAULT_APPEND_TABLE_NAMESto thedb_creatormodule, and update references toAPPEND_TABLE_NAMES, so that the metadata tables don't have to be specified in the config. (issue Create DEFAULT_APPEND_TABLES, so we don't have to define metadata tables in env file #66)DBCreator, which was requested by @lsloan (issue make DBCreator class implement fluent interface #84).self.conn,self.set_up, andself.tear_downfromDBCreatorclass (these just caused confusion and really we can use the SQLAlchemy API off ofself.enginefor creating and dispensing with connection objects as needed) (issue Remove self.conn, set_up, and tear_down methods from DBCreator #109).