This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Handle possibility of duplicate courses being inserted to course table (#174)
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushyamig
approved these changes
May 21, 2020
|
If you want to test this, you can do something like this (from a testing branch): https://github.com/ssciolla/course-inventory/blob/f448a2f77feed0b353c8d570302f5b089ca37dfc/course_inventory/inventory.py#L178-L188 |
ssciolla
commented
May 21, 2020
ssciolla
changed the title
course table (#174)
zqian
approved these changes
May 22, 2020
ssciolla
changed the title
course table (#174)course table (#174)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR #146, this PR adds duplicate dropping to the creation of
courserecords to avoid possible errors when inserting into the database. The modifications include the use ofpd.DataFrame.drop_duplicateswith thesubsetparameter to limit duplicate consideration to the PK (canvas_id) and thekeepparameter to ensure the second record found is kept. This change is responding to incidents in the production and test processes where a different course in each process seems to have been duplicated. The PR aims to resolve issue #174.