Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

define MiVideo table relationships (#183) #194

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

lsloan
Copy link
Member

@lsloan lsloan commented Jun 10, 2020

Resolves #183.

Summary

Add relationships between mivideo_media_courses and mivideo_media_created tables.

Review

I humbly request that comments on this PR be nested under a single review per reviewer. It helps me when the comments are organized this way, especially if the comments request changes in the code.

If I've requested a review from you but you are definitely unable to review this PR, please leave a comment saying so (please state why you're unable to review, that would be appreciated), tell the other reviewers that the review will be left to them, and remove your name from the list of reviewers.

@lsloan lsloan self-assigned this Jun 10, 2020
@lsloan lsloan marked this pull request as ready for review June 10, 2020 20:29
@lsloan lsloan changed the title Define MiVideo table relationships (#183) define MiVideo table relationships (#183) Jun 11, 2020
@lsloan lsloan added the 🔞 minor low priority label Jun 12, 2020
Copy link
Contributor

@ssciolla ssciolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment, feel free to ignore.

db/migrations/0021.add_mivideo_fk.py Show resolved Hide resolved
@lsloan lsloan merged commit 93885ed into tl-its-umich-edu:master Jun 15, 2020
@lsloan lsloan deleted the 183-mivideo-table-relationship branch June 15, 2020 20:43
@lsloan lsloan added this to the 2020.02.02 release milestone Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define MiVideo table relationships
2 participants