Update dependencies again #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zqian
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Tested with assignment title containing assignment with special characters: ":", "-", "--", "/", "%", "*", "?", ".", and ";"
Verified the fix working in devumich arcgis server
|
We will hold off on merging these changes until we hear from the ArcGIS team on their dependency recommendations. |
|
Thanks for the review, @zqian! |
|
@lsloan, this is pretty stale, so it might need some work from you before it's merge-able. I'd take a look at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #49 to bump the Python base image to
3.9-slim, thearcgismodule to1.9.1, and thebeautifulsoup4module to4.10.0.cachetoolswas also added, as it now appears to be a minimum dependency ofarcgis(follow this post here). The PR is related to #48.Note(s):
ujson,requests, andcachetools(chose second to latest when adding), because they came after the latestarcgisrelease; let me know if that makes sense to you, or if I should go ahead with updating them.