-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pages*/osx/*: apply keypress specifications #15858
base: main
Are you sure you want to change the base?
Conversation
Should the Ctrl keys be converted to the mac equivalent? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spanish chapter: LGTM
What is "the Mac equivalent" to you? The Option-key or the Command-key? Or anything else? |
I don't know. That's why I'm asking and hoping someone more knowledgeable answers. |
It's not. Cmd is the Windows-key, Option is the Alt-key and Control is the Ctrl-key. |
I see. Are you on a mac? Can you test what keys |
I am. |
Is Also make one commit suggestion so that you get credit when this gets squash merged. |
I do not care that much about the credits for this work. |
Hello! I've noticed something unusual when checking this PR:
Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits. |
#15798
These required a bit of trickery to find. I used various methods such as
grep -r "<" | grep ">" | grep -v http | sort
,grep -ri "ctrl"
,grep -ri "alt"
,grep -Er '`.`'
andgrep -Er '`[^\n]*[A-Z]+[^\n]*`'
,grep -ri "cmd"
,grep -ri "option"
Should the Ctrl keys be converted to the mac equivalent?