Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages*/osx/*: apply keypress specifications #15858

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Mar 4, 2025

#15798

These required a bit of trickery to find. I used various methods such as grep -r "<" | grep ">" | grep -v http | sort, grep -ri "ctrl", grep -ri "alt", grep -Er '`.`' and grep -Er '`[^\n]*[A-Z]+[^\n]*`', grep -ri "cmd", grep -ri "option"

Should the Ctrl keys be converted to the mac equivalent?

@github-actions github-actions bot added page edit Changes to an existing page(s). review needed Prioritized PRs marked for reviews from maintainers. labels Mar 4, 2025
@github-actions github-actions bot added the translation edit Changes to an existing translation page(s). label Mar 4, 2025
@Managor Managor requested review from kant, tricantivu and ikks as code owners March 4, 2025 20:00
@github-actions github-actions bot added the mass changes Changes that affect multiple pages. label Mar 4, 2025
@Managor
Copy link
Collaborator Author

Managor commented Mar 4, 2025

Should the Ctrl keys be converted to the mac equivalent?

@Managor Managor changed the title pages/osx/*: apply keypress specifications pages*/osx/*: apply keypress specifications Mar 5, 2025
Copy link
Member

@kant kant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish chapter: LGTM

@sebastiaanspeck
Copy link
Member

Should the Ctrl keys be converted to the mac equivalent?

What is "the Mac equivalent" to you? The Option-key or the Command-key? Or anything else?

@Managor
Copy link
Collaborator Author

Managor commented Mar 6, 2025

I don't know. That's why I'm asking and hoping someone more knowledgeable answers.
Judging by the translations Cmd seems to be Ctrl equivalent.

@sebastiaanspeck
Copy link
Member

I don't know. That's why I'm asking and hoping someone more knowledgeable answers.

Judging by the translations Cmd seems to be Ctrl equivalent.

It's not. Cmd is the Windows-key, Option is the Alt-key and Control is the Ctrl-key.

@Managor
Copy link
Collaborator Author

Managor commented Mar 6, 2025

I see. Are you on a mac? Can you test what keys caffeinate responds to?

@sebastiaanspeck
Copy link
Member

sebastiaanspeck commented Mar 6, 2025

I see. Are you on a mac? Can you test what keys caffeinate responds to?

I am. Give me a minute Edit: It just responds to Ctrl - c, So Control - c.

@Managor
Copy link
Collaborator Author

Managor commented Mar 6, 2025

Is <Ctrl c> good enough for mac users or are you more used to <Control c>. I would prefer <Ctrl c> to reduce horizontal width, but I can't argue with platform specific notation.

Also make one commit suggestion so that you get credit when this gets squash merged.

@sebastiaanspeck
Copy link
Member

sebastiaanspeck commented Mar 6, 2025

Is <Ctrl c> good enough for mac users or are you more used to <Control c>. I would prefer <Ctrl c> to reduce horizontal width, but I can't argue with platform specific notation.

<Ctrl c> sounds good enough to me, although <Ctrl + c> looks the best to me.

Also make one commit suggestion so that you get credit when this gets squash merged.

I do not care that much about the credits for this work.

@tldr-bot
Copy link

tldr-bot commented Mar 6, 2025

Hello! I've noticed something unusual when checking this PR:

  • The page pages.de/osx/caffeinate.md is outdated, based on number of commands, compared to the English page.
  • The page pages.id/osx/caffeinate.md is outdated, based on number of commands, compared to the English page.
  • The page pages.it/osx/caffeinate.md is outdated, based on number of commands, compared to the English page.
  • The page pages.pl/osx/caffeinate.md is outdated, based on number of commands, compared to the English page.
  • The page pages.zh/osx/caffeinate.md is outdated, based on number of commands, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). review needed Prioritized PRs marked for reviews from maintainers. translation edit Changes to an existing translation page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants