add serde support #278
Draft
add serde support #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zefr0x
commented
Jan 5, 2025
Comment on lines
-33
to
+34
| pulp = "^0.18.9" | ||
| pulp = { git = "https://github.com/zefr0x/pulp.git", branch = "implserde", features = ["serde"] } |
There was a problem hiding this comment.
Before merging this, pulp should support serde first.
Temporary I have a fork that does it partially to make things work, but it should be upstreamed for new versions.
Also, I don't really know if pulp::Arch is important to be serialized or if it can be reconstructed from other values in the struct, is it possible to drop it?
|
Also, I'm not sure that every thing is covered or if something must not be serialized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable serialization and deserialization of keys and ciphers.
Closes: #137