Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agents: add CallOptions to Plan() (issue #353) #857

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

disk0Dancer
Copy link

@disk0Dancer disk0Dancer commented May 25, 2024

Hi! I saw an issue #353 during usage package and made implementation.)

I have fixed problem for almost all agent types but not for OpenAI.
I do not really understand how to work with theirs API, have no keys..

What do you think about solution?

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@disk0Dancer disk0Dancer changed the title agents(#353): add CallOptions to Plan() agents: add CallOptions to Plan() (issue #353) May 28, 2024
@@ -67,10 +68,12 @@ func (o *OpenAIFunctionsAgent) functions() []llms.FunctionDefinition {
}

// Plan decides what action to take or returns the final result of the input.
// TODO(fix): add {options ...chains.ChainCallOption} to llm request.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not implement this here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants