Fix crash in dynamic module_function within a loop

tmm1 · Feb 10, 2024 · f0c27ab · f0c27ab
1 parent 2fcd7c9
commit f0c27ab
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/ripper-tags/parser.rb b/lib/ripper-tags/parser.rb
@@ -220,7 +220,7 @@ def on_method_add_arg(call, args)
           method_name = args[1][1]
         end
 
-        [procedure, klass, method_name, access, line]
+        [procedure, klass, method_name, access, line] if method_name
       when "scope", "named_scope"
         scope_name = args[1][0]
         [:rails_def, :scope, scope_name, line] if scope_name

diff --git a/test/test_ripper_tags.rb b/test/test_ripper_tags.rb
@@ -258,6 +258,17 @@ def def() end
     assert_equal('method',           module_tags.find{ |t| t[:name] == 'def' }[:kind])
   end
 
+  def test_dynamic_module_function
+    tags = extract(<<-RUBY)
+      module Airbrussh
+        ANSI_CODES.each do |name, code|
+          module_function(name)
+        end
+      end
+    RUBY
+    assert_equal ["Airbrussh"], tags.map { |t| t.fetch(:name) }
+  end
+
   def test_extract_one_line_definition_access_by_symbol
     %w(private public protected).each do |visibility|
       tags = extract(<<-EOC)