update byoc doc

[xytian315]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug
/kind cleanup
/kind deprecation
/kind design

/kind documentation

/kind feature
/kind release

What this PR does / why we need it:
update byoc doc
Which issue(s) this PR fixes:

Fixes #102

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., usage docs, etc.:

[phenixblue]

I've been away on Holliday and am just returning. I will still be slow to respond as I get caught up with things, but hope to get this reviewed soon.

[phenixblue]

One quick note, please setup commit signing for your contributions. I just realized we have that enforcing, but don't have it documented in the CONTRIBUTING.md file (my apologies for any confusion). I opened #117 to track the addition of that info to the Contributing Docs.

More info on how to setup commit signing can be found here:

https://docs.github.com/en/authentication/managing-commit-signature-verification/displaying-verification-statuses-for-all-of-your-commits

[xytian315]

One quick note, please setup commit signing for your contributions. I just realized we have that enforcing, but don't have it documented in the CONTRIBUTING.md file (my apologies for any confusion). I opened #117 to track the addition of that info to the Contributing Docs.

More info on how to setup commit signing can be found here:

https://docs.github.com/en/authentication/managing-commit-signature-verification/displaying-verification-statuses-for-all-of-your-commits

Done! Thanks so much!

[phenixblue]

A couple of small things.

[xytian315]

there is one problem I noticed that, in the init code, when the secret exists, we were "Waiting for race winning pod to startup" by checking magtape/updated-by-pod label, and this label will not be added if magtape_tls_byoc, so when magtape_tls_byoc, there will be an error since no such label exist magtape/updated-by-pod. I added a commit a7f7bb7, just add a condition
if not magtape_tls_byoc: to the existing logic of checking magtape/updated-by-pod label.

I tested locally, the init container started successfully.

[xytian315]

FYI: another small issue I ran with is that the black version I installed locally wasn't exactly the same as what we are specifying in the CI job. So previously when I run make ci-lint-python, there were a lot of changes in other files, which I didn't check in earlier.

I noticed from last CI job here https://github.com/tmobile/magtape/runs/4892244656?check_suite_focus=true, there was a specific black version, I changed them locally accordingly and create a new commit to fix the issue 3c8ef3d
Hopefully this fixed the CI job 🤞

Maybe we can change the contribution guide to specify the black version we are using in CI job.

[phenixblue]

False positive on the codeQL check

/lgtm