Fix 405 issue #30
Merged
Fix 405 issue #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of rendering the login template on 401s, we redirect to the login page. The login page will now redirect to ?next after it has validated the URL is safe. This fixes the issue with trying to log in from pages that aren't /login. Signed-off-by: Josh Farwell <[email protected]>
We want to avoid circular imports so we instantiate login_manager in views and then initialize it in application.py. Signed-off-by: Josh Farwell <[email protected]>
Turns out that Flask-Login implements the redirect chain by itself. It doesn't validate the redirect URL though. Signed-off-by: Josh Farwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of rendering the login template on 401s, we redirect to the
login page. The login page will now redirect to ?next after it has
validated the URL is safe and logged the user in. This fixes the issue
with trying to log in from pages that aren't /login.
This is a pretty standard way of doing this, we're checking against the host header to make sure the URL belongs to us and it serves 400s for bad URLs.
Signed-off-by: Josh Farwell [email protected]