Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for package references (PackageReference) in project files #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehusakovic
Copy link

Package references, using the PackageReference node, manage NuGet dependencies directly within project files (as opposed to a separate packages.config file).
https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files

When this is used the tools folder location changes to /packages/{package_name}/{version}/tools. Furthermore the default packages location moves to the windows Users folder.

Therefore the existing logic for getting the transformer.exe location is not correct for the projects using ProjectReference.

I suggest using the powershell automatic variable $PSScriptRoot to get the path to the running script to locate transformer.exe.

@tobiaszuercher
Copy link
Owner

hey @ehusakovic
sorry for the late answer. a lot of things are going on. but thank you for your PR!

i just tested your change and i think it makes sense to apply. unfortunately something is wrong with my automated deployment pipeline. i'll check it and will push it soon.

btw1: i'd be interested where transformer is used, also by pm if it should not be public.
btw2: i am working an on version v2.0 in .net CORE which will be a nuget client tool instead of powershell https://docs.microsoft.com/en-us/nuget/install-nuget-client-tools (backward compatibility will be provided). it will get a better "cli feeling".

@ehusakovic
Copy link
Author

Hi @tobiaszuercher
it's ITMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants