Fix multipleOf bugs
#114
Merged
Fix multipleOf bugs
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
round() always returns a float
|
@tobyzerner as with the previous PR this would be useful to have in the |
- `%d` casts the multipleOf to a whole number even if its a float with decimals - `%f` would add unnecessary decimals, e.g. `0.01` would become `0.010000` - `%s` maintains the same number of decimals, e.g. `0.01` stays `0.01`
|
Clever solution @bertramakers, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #113
I figured out how to fix the
multipleOfvalidation without using the modulo operator which doesn't work when using amultipleOfvalue that is afloatwith decimals, caused by the modulo operator converting themultipleOfvalue to integer.The new validation divides the value of the field by the
multipleOfvalue (if not null). If the value is indeed a multiple of themultipleOfproperty, the result should always be a whole number. We can check this by comparing it to the same result but rounded.