Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: lora: Store the LoRa keys in the K/V store #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alistair23
Copy link
Contributor

@alistair23 alistair23 commented Aug 1, 2024

This builds on top of #456, which builds on top of #432 to store the LoRaWAN keys in K/V storage.

This modifies the LoRaWAN example to use keys set in Tock's K/V store.
The lorawan-set-keys application is added to set keys, which can then
be used over and over again by the LoRaWAN transmit application.

This means that once a board has been flashed the LoRaWAN application can easily be changed without worrying about keys. It also opens up the possibility of storing the keys from a side application (such as a BLE interface).

@alistair23 alistair23 force-pushed the alistair/lora-keys branch 2 times, most recently from 9ce20db to d49f6e6 Compare August 1, 2024 10:13
@ppannuto ppannuto added the blocked Blocked on promised changes or other PRs label Oct 2, 2024
@ppannuto
Copy link
Member

ppannuto commented Oct 2, 2024

Sorry things have been slow in libtock-c. Life is letting up a bit and I should have more time to attend to stuff here in a more timely manner moving forward.

Ideally, we can get #456 in next week and then can look at this one. [btw, is it feasible to have as a merge base target PR#456, i.e. alistair23:alistair/lora-wan? That'd make it a lot easier to review this PR in advance; though I'm not sure if github lets you do a PR to a branch like that and still have it show up in the main tock/libtock-c repo :/]

@alistair23
Copy link
Contributor Author

alistair23 commented Oct 2, 2024

This is rebased and ready to go.

btw, is it feasible to have as a merge base target PR#456, i.e. alistair23:alistair/lora-wan? That'd make it a lot easier to review this PR in advance; though I'm not sure if github lets you do a PR to a branch like that and still have it show up in the main tock/libtock-c repo :/

Not that I know of. Each one is cleaning rebased on the previous PR, so it's easy to track the changes in git, but I have no idea how to do that in GitHub

@ppannuto ppannuto removed the blocked Blocked on promised changes or other PRs label Nov 13, 2024
@ppannuto
Copy link
Member

Sorry #456 took so long; hopefully this is a relatively painless rebase of the new commits

@alistair23 alistair23 force-pushed the alistair/lora-keys branch 2 times, most recently from dee7168 to cec2f05 Compare November 15, 2024 01:26
@alistair23
Copy link
Contributor Author

This is rebased

This modifies the LoRaWAN example to use keys set in Tock's K/V store.
The `lorawan-set-keys` application is added to set keys, which can then
be used over and over again by the LoRaWAN transmit application.

Signed-off-by: Alistair Francis <[email protected]>
@alistair23
Copy link
Contributor Author

Ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants