Implement Subscribe in libtock_unittest::fake::Kernel.
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvanwhy
added
the
significant
hudson-ayers
approved these changes
Sep 8, 2021
alistair23
approved these changes
Sep 8, 2021
bors bot
added a commit
that referenced
this pull request
Sep 11, 2021
330: `libtock_unittest`: make Yield invoke queued upcalls. r=jrvanwhy a=jrvanwhy With this PR, calling the Yield system calls will correctly invoke queued upcalls. This PR and #329 implement the fake Subscribe implementation in `libtock_unittest`. 331: Implement a fake LowLevelDebug API. r=jrvanwhy a=jrvanwhy This is the first proper `fake::Driver` implementation! Co-authored-by: Johnathan Van Why <[email protected]>
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #326 , this does not have a full unit test suite because it was getting too large. Instead, I'll be adding the unit tests that need additional infrastructure (a
fake::Driver) later, and have a TODO to remind myself.I added some conversions between
Register,ErrorCode, andReturnVariant. I'm not sure what these conversions should look like (some of the code is kind of awkward), so I opened #328 to take another look in the future.