Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): table block supports parsing rich text #10430

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

zzj3720
Copy link
Member

@zzj3720 zzj3720 commented Feb 25, 2025

fix: BS-2685

Copy link

graphite-app bot commented Feb 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.16%. Comparing base (f3911b1) to head (2ef39f3).

Files with missing lines Patch % Lines
blocksuite/affine/block-table/src/adapters/html.ts 0.00% 2 Missing ⚠️
...locksuite/affine/block-table/src/adapters/utils.ts 85.71% 2 Missing ⚠️
...uite/affine/block-table/src/adapters/plain-text.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10430      +/-   ##
==========================================
- Coverage   54.21%   54.16%   -0.06%     
==========================================
  Files        2340     2340              
  Lines      108177   108169       -8     
  Branches    17890    17888       -2     
==========================================
- Hits        58653    58588      -65     
- Misses      48199    48233      +34     
- Partials     1325     1348      +23     
Flag Coverage Δ
server-test 78.95% <ø> (+<0.01%) ⬆️
unittest 31.17% <63.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzj3720 zzj3720 marked this pull request as ready for review February 25, 2025 13:13
@zzj3720 zzj3720 requested a review from a team as a code owner February 25, 2025 13:13
@graphite-app graphite-app bot requested review from a team February 25, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant