Fix SyntaxWarning for '\w' '\d' in regexes #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincele
force-pushed
the
fix-regex-literals
branch
from
affc608
to
b8007ad
Compare
|
Tested with a simple 10s run: logfile contains: |
|
I went for the minimal fix, and did not touch the other regexes. But a quick grep showed that the non-raw strings regexes are the minority, so maybe you'll want the full conversion... I can do that, in addition to the simple fix or a single commit for the lot. What do you think ? |
|
Thanks for the fix! Yeah, we should use raw strings throughout. Please feel free to fix up all instances! :)
…On 21 June 2024 23:39:40 CEST, Vincent Legoll ***@***.***> wrote:
I went for the minimal fix, and not touched the other regexes.
But a quick grep showed that the non-raw strings regexes are the minority, so maybe you'll want the full conversion...
I can do that, in addition to the simple fix or a single commit for the lot.
What do you think ?
|
Use raw string literals for the affected regexes
(venv-flent) $ flent -V
/path/to/flent/flent/metadata.py:247: SyntaxWarning: invalid escape sequence '\d'
m = re.search("(qlen|txqueuelen) (\d+)", output)
/path/to/flent/flent/metadata.py:259: SyntaxWarning: invalid escape sequence '\w'
m = re.search("Duplex: (\w+)", output)
Starting Flent 2.1.1+git.6c8dce50 using Python 3.12.4.
Flent v2.1.1+git.6c8dce50.
Running on Python 3.12.4 (main, Jun 9 2024, 22:05:49) [GCC 13.2.0].
No matplotlib found. Plots won't be available.
No usable Qt version found. GUI won't work.
ERROR: Missing test name.
Signed-off-by: Vincent Legoll <[email protected]>
Signed-off-by: Vincent Legoll <[email protected]>
vincele
force-pushed
the
fix-regex-literals
branch
from
b8007ad
to
b013fee
Compare
|
also tested OK |
tohojo
approved these changes
Jun 23, 2024
|
I gave a quick glance at each test suite failure, for this PR, Probably not related to the PR modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use raw strings literals for the affected regexes
(venv-flent) $ flent -V
/path/to/flent/flent/metadata.py:247: SyntaxWarning: invalid escape sequence '\d'
m = re.search("(qlen|txqueuelen) (\d+)", output)
/path/to/flent/flent/metadata.py:259: SyntaxWarning: invalid escape sequence '\w'
m = re.search("Duplex: (\w+)", output)
Starting Flent 2.1.1+git.6c8dce50 using Python 3.12.4. Flent v2.1.1+git.6c8dce50.
Running on Python 3.12.4 (main, Jun 9 2024, 22:05:49) [GCC 13.2.0]. No matplotlib found. Plots won't be available.
No usable Qt version found. GUI won't work.
ERROR: Missing test name.