Add 'config print'. #727
Merged
Add 'config print'. #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
approved these changes
Jun 16, 2023
| @@ -23,12 +23,15 @@ import fs | |||
| import .utils | |||
|
|
|||
| APP_NAME ::= "artemis" | |||
|
|
|||
| // When adding a new config don't forget to update the 'config show' command. | |||
There was a problem hiding this comment.
Suggested change
| // When adding a new config don't forget to update the 'config show' command. | |
| // When adding a new config don't forget to update the 'config print' command. |
| CONFIG_DEVICE_DEFAULT_KEY ::= "device.default" | ||
| CONFIG_BROKER_DEFAULT_KEY ::= "server.broker.default" | ||
| CONFIG_ARTEMIS_DEFAULT_KEY ::= "server.artemis.default" | ||
| CONFIG_SERVERS_KEY ::= "servers" | ||
| CONFIG_SERVER_AUTHS_KEY ::= "auths" | ||
| CONFIG_ORGANIZATION_DEFAULT_KEY ::= "organization.default" | ||
| // When adding a new config don't forget to update the 'config show' command. |
There was a problem hiding this comment.
Suggested change
| // When adding a new config don't forget to update the 'config show' command. | |
| // When adding a new config don't forget to update the 'config print' command. |
src/cli/cmds/config.toit
Outdated
| --run=:: show_config config ui | ||
|
|
||
| config_cmd.add show_cmd | ||
| print_cmd := cli.Command "print" |
There was a problem hiding this comment.
It feels like we're just getting the config here. Printing isn't really that interesting. Also, we still use 'device show'.
For configuration options, we often have 'config xxx' to show and 'config xxx 1234' to set, no?
Also, see #472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes toitware/artemis-releases#51