-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the textures, now it's Elements only. #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 2 of the pixel-display, the textures are going away, and will be replaced by elements. The display as a whole will have a 2d transform (rotation), and the individual elements (windows) will have only an internal offset, not a full transform. The Canvases know their offset relative to the scene, and will eventually gain drawing operations. For now we just rename them, to put more emphasis on the abstract class at the top of the hierarchy, which will be more important going forward than the various bit depth variants. Start to move bar code code out of the core files. Start common.toit which will have code common to textures and elements in the transition period. All drivers must know their rounding requirements going forward. Some changes for recent SDKs. We now require alpha 121.
Uses pngdiff from toit-png-tools as a submodule in order to make a diff when test results diff from gold. This lets us use highly compressed pngs in the gold directory.
Also makes update canvases more square and less elongated, which can be good for performance.
floitsch
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.