Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EAN barcodes. #57

Merged
merged 116 commits into from
Dec 7, 2023
Merged

Add EAN barcodes. #57

merged 116 commits into from
Dec 7, 2023

Conversation

erikcorry
Copy link

No description provided.

Erik Corry added 22 commits December 4, 2023 11:36
In version 2 of the pixel-display, the textures are going
away, and will be replaced by elements.

The display as a whole will have a 2d transform (rotation),
and the individual elements (windows) will have only an internal
offset, not a full transform.

The Canvases know their offset relative to the scene, and
will eventually gain drawing operations.  For now we just
rename them, to put more emphasis on the abstract class
at the top of the hierarchy, which will be more important
going forward than the various bit depth variants.

Start to move bar code code out of the core files.

Start common.toit which will have code common to
textures and elements in the transition period.

All drivers must know their rounding requirements going
forward.

Some changes for recent SDKs.  We now require alpha 121.
Uses pngdiff from toit-png-tools as a submodule
in order to make a diff when test results diff
from gold.  This lets us use highly compressed
pngs in the gold directory.
Also makes update canvases more square and
less elongated, which can be good for
performance.
Also adds simple solid borders.
@erikcorry erikcorry requested a review from floitsch December 4, 2023 21:45
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

else:
super key value

code_ := ? // 13 digit code as a string.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Suggested change
code_ := ? // 13 digit code as a string.
code_/string := ? // 13 digit code as a string.

// Use of this source code is governed by a Zero-Clause BSD license that can
// be found in the TESTS_LICENSE file.

// Tests for TextElement that the change box is smaller when we only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment.

Base automatically changed from erik-650-png to main December 7, 2023 14:46
@erikcorry erikcorry merged commit 2b36b1d into main Dec 7, 2023
3 checks passed
@erikcorry erikcorry deleted the erik-700-barcodes branch December 7, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants