Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to update the PNG file on a PNG element #93

Merged
merged 10 commits into from
Mar 9, 2024
Merged

Make it possible to update the PNG file on a PNG element #93

merged 10 commits into from
Mar 9, 2024

Conversation

erikcorry
Copy link

No description provided.

@erikcorry erikcorry requested a review from floitsch March 8, 2024 14:38
floitsch
floitsch approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
an alternative would be to have a zero-png constant instead of all the nulls.

@erikcorry erikcorry merged commit e755a89 into main Mar 9, 2024
3 checks passed
@erikcorry erikcorry deleted the png-update branch March 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikcorry @floitsch