Add way to improve performance by using more memory #96
Conversation
src/pixel-display-impl_.toit
Outdated
| multiple color components, transparency, and clipping, so the | ||
| effective memory use may be higher than this number. | ||
| */ | ||
| max-patch-size/int := 2000 |
There was a problem hiding this comment.
Maybe make it := ? and always set it in the constructor?
Otherwise you might get misled by just looking here (and not realizing that some displays, like the two-color one) set it to a different value.
You could also have TWO-COLOR-DEFAULT-PATCH-SIZE... constants.
| @@ -77,6 +77,17 @@ abstract class PixelDisplay implements Window: | |||
| inner-width: return driver_.width | |||
| inner-height: return driver_.width | |||
|
|
|||
| /** | |||
| By default, the display is rendered in patches that have | |||
| a max size of 2-8k, depending on the bits per pixel. On devices | |||
There was a problem hiding this comment.
| a max size of 2-8k, depending on the bits per pixel. On devices | |
| a max size of 2-8k pixels, depending on the bits per pixel. On devices |
There was a problem hiding this comment.
From a user's point of view setting the memory used might be easier. Like "you are allowed to use 20K of RAM for each patch". Not really sure about that.
There was a problem hiding this comment.
That's what it is already though.
There was a problem hiding this comment.
Why does the TwoColorPixelDisplay then set it to a higher value? I would have expected the 2-color display to use the least amount of memory.
No description provided.