Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve weighting with flex search #302

Merged
merged 9 commits into from
Nov 22, 2021
Merged

Improve weighting with flex search #302

merged 9 commits into from
Nov 22, 2021

Conversation

enyo
Copy link
Contributor

@enyo enyo commented Nov 17, 2021

This is the first basic implementation that gives different weight to: the page name, h1, h2, h3, and the body (in descending order).

There are a few further improvements to this that I've written down in #303

Closes #292 #291

@enyo enyo mentioned this pull request Nov 17, 2021
5 tasks
@enyo enyo requested a review from jstroem November 17, 2021 11:19
Copy link
Contributor

@jstroem jstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gatsby-node.js Outdated Show resolved Hide resolved
src/hooks/use_flex_search.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jstroem jstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/search/SearchBar.tsx Outdated Show resolved Hide resolved
src/hooks/use_result_selection.ts Show resolved Hide resolved
@enyo enyo enabled auto-merge (squash) November 22, 2021 09:43
@enyo enyo merged commit c82c9e0 into master Nov 22, 2021
@enyo enyo deleted the flex_search branch November 22, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an actual search result page
2 participants