Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.6.x] Update tokio-tungstenite 0.20 #2123

Merged
merged 3 commits into from
Aug 2, 2023
Merged

[v0.6.x] Update tokio-tungstenite 0.20 #2123

merged 3 commits into from
Aug 2, 2023

Conversation

alexheretic
Copy link
Contributor

#2116 for v0.6.x.

  • Update tokio-tungstenite to 0.20
  • Add WebSocketUpgrade::write_buffer_size and WebSocketUpgrade::max_write_buffer_size
  • Deprecate WebSocketUpgrade::max_send_queue which now does nothing.

@alexheretic
Update tokio-tungstenite 0.20
614ad4e 
Deprecate WebSocketUpgrade::max_send_queue
Add WebSocketUpgrade::write_buffer_size, max_write_buffer_size
@alexheretic
Update changelog
a664d9b
@alexheretic alexheretic mentioned this pull request Jul 26, 2023
Merged
jplatte
jplatte reviewed Jul 27, 2023
View reviewed changes
axum/src/extract/ws.rs Outdated Show resolved Hide resolved
axum/src/extract/ws.rs Outdated Show resolved Hide resolved
jplatte
jplatte approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will let David take a look / merge

davidpdrsn
davidpdrsn approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@davidpdrsn davidpdrsn merged commit 990cbb8 into tokio-rs:v0.6.x Aug 2, 2023
17 checks passed
@alexheretic alexheretic deleted the 0.6-tungstenite-0.20 branch August 2, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexheretic @davidpdrsn @jplatte