Avoid clone in layer #2973
Merged
Avoid clone in layer #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanns
commented
Oct 10, 2024
| @@ -924,6 +925,26 @@ async fn state_isnt_cloned_too_much() { | |||
| assert_eq!(state.count(), 3); | |||
| } | |||
|
|
|||
| #[crate::test] | |||
| async fn state_isnt_cloned_too_much_in_layer() { | |||
There was a problem hiding this comment.
I'm not sure if it's the right place to put this test
jplatte
approved these changes
Oct 10, 2024
| @@ -924,6 +925,26 @@ async fn state_isnt_cloned_too_much() { | |||
| assert_eq!(state.count(), 3); | |||
| } | |||
|
|
|||
| #[crate::test] | |||
| async fn state_isnt_cloned_too_much_in_layer() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2865
The first commit introduces a test to cover the state cloning
The second commit removes one clone