Upgrade matchit #2997
Merged
Upgrade matchit #2997
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failed because of change in casing of a panic message. Otherwise looks good, let's do it. |
jplatte
force-pushed
the
jplatte/matchit-version
branch
from
d4a2897
to
8295007
Compare
jplatte
force-pushed
the
jplatte/matchit-version
branch
from
8295007
to
a34b73e
Compare
mladedav
reviewed
Oct 21, 2024
There was a problem hiding this comment.
The way you had it before, we wouldn't upgrade to 0.8.5, but with the current change we would.
I just checked that it should be fine with the PR with suffixes (or at least tests seem to pass), but users still won't be able to use the suffixes because we make some checks regarding captures like making sure that the whole path segment is captured.
So I just want to make sure that this is intended.
jplatte
commented
Oct 21, 2024
|
Wasn't intended 😅 |
mladedav
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A few patch versions have been release since 0.8.0, but the anticipated problematic change (ibraheemdev/matchit#61) has not landed yet.
Solution
Bump the version requirement.