Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: allow pin-project-lite in public dependencies #3020

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

mladedav
Copy link
Collaborator

@mladedav mladedav commented Nov 7, 2024

Motivation

CI is currently failing because our public dependencies seem to include pin-project-lite. This seems to have started failing without any changes so it might be one of our previous public dependencies changed something which exposed pin-project-lite and it is now visible also from axum. But I didn't see any information about where the dependency is exposed or anything like that so this is just an assumption on my part.

Solution

Allow the public dependency to unblock other PRs by fixing the CI.

It should be noted that if the assumption that we're exposing the project indirectly through another dependency, then it is also potentially exposed in the already released versions with latest transitive dependencies so this PR might be just blessing the current state.

Future Work

We should consider how we want to handle this in the future. The cargo-public-api-crates project doesn't seem to have any maintenance for some time. We can continue using it as a check that we didn't do something unintended and in cases like this we can change the expected set without fully understanding where a dependency comes from. Other options include someone stepping up to help maintain the project and discarding the check.

@mladedav mladedav force-pushed the dm/fix-public-deps branch 2 times, most recently from 3c1011c to 84f31b6 Compare November 7, 2024 14:10
@mladedav mladedav requested a review from jplatte November 7, 2024 14:33
@mladedav mladedav marked this pull request as ready for review November 7, 2024 14:34
@jplatte
Copy link
Member

jplatte commented Nov 7, 2024

Thanks! This seems like a good short-term solution. Long term it would be very cool if somebody picked up that project. I'll try to find some time for it soon, but I don't have high hopes ^^

@mladedav mladedav merged commit 269565f into main Nov 7, 2024
18 checks passed
@mladedav mladedav deleted the dm/fix-public-deps branch November 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants