task commit #1
Open
task commit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaguya3222
reviewed
Oct 17, 2024
added 2 commits
October 28, 2024 22:50
|
You have 2 lock files from 2 different package managers:
|
|
Let's make this app to support breakpoints from 360px |
|
why do you need |
kaguya3222
reviewed
Oct 29, 2024
| }, [countriesData]); | ||
|
|
||
| const updateQuestion = (option) => { | ||
| if (answers[activeStageIndex] === undefined) { |
There was a problem hiding this comment.
Instead of nesting code inside in if it's better to use conditional guard
if (answers[activeStageIndex]) return
setAnswers((prevAnswers) => ({
...prevAnswers,
[activeStageIndex]: option,
}));
https://refactoring.guru/uk/replace-nested-conditional-with-guard-clauses
| return []; | ||
| }, [countriesData]); | ||
|
|
||
| const updateQuestion = (option) => { |
There was a problem hiding this comment.
option -> answer
I see a lot of abstract namings, please pay attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.