Responsive Layout and Theme Mixins #176
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/konzepz/mels-loop-nextjs/2oe21jfYNZHXUpe55mXYJVLeT9y2 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <TooltipContent> | ||
| <Portalled> | ||
| <div className={contentStyle(contentClasses.root)}> | ||
| Copied! |
| <p className={classes.linkText}> | ||
| {type === "article" ? author : description} | ||
| </p> | ||
| <a href={url} className={classes.menuLink}> |
There was a problem hiding this comment.
Check thesis about reload and routing
There was a problem hiding this comment.
Checked; turns out there was a problem and the page did render on every menu click.
Changed the Radix UI component to Next Link.
Also removed target as it is not currently used, in order to fix Site Title Link.
| export const CopyUrlButton = ({ | ||
| query, | ||
| className, | ||
| }: ICopyUrlButtonProps): JSX.Element => { | ||
| const [toggleCopyIcon, setToggleCopyIcon] = useState(false); | ||
|
|
||
| const onCopy = () => { |
There was a problem hiding this comment.
Check how to move timeout to useEffect
| className={st(classes.copy, classes.item)} | ||
| /> | ||
| )} | ||
| <PopoverCloseButton |
There was a problem hiding this comment.
Close button should be instantiated by useToolbar
| }: LocaleSelectorProps): JSX.Element => { | ||
| const { locale, locales, getLocaleSymbol } = useContext(ReactLocaleContext); | ||
| export const LocaleSelector = ({ className }: ComponentProps): JSX.Element => { | ||
| const { locale, locales, getLocaleSymbol, onLocaleChange } = |
There was a problem hiding this comment.
Move context to layout
There was a problem hiding this comment.
Had a lot of thoughts regarding this issue since our discussion. I summarized it in this discussion thread: #181
Also, I sent out a shout out to the Next community and to the React community over Reddit. I'm curios what feedback we'll get there.
src/contexts/query-manager.tsx
Outdated
| @@ -37,6 +37,10 @@ export class QueryManager implements IQueryManager { | |||
| return this.asPath.split("?"); | |||
| } | |||
|
|
|||
| get isHome() { | |||
There was a problem hiding this comment.
Disable isHome feature for logo
LightandDarkthemeisHomemethod moved toQueryContextonLocaleChangemethod moved toLocaleContextTopBarto a component (theming and concerns)commonimports, in attempt to have only Themes use itNav)PortalledComponent for styling portal components