Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ldflags to 'go build' cmd to bring back version number #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dotcs
Copy link

@dotcs dotcs commented May 6, 2022

In v0.7.1 the -ldflags "-X main.gronVersion=${VERSION}" argument to the go build cmd has been removed.

This PR reverts this change and re-introduces the flag to show the correct version string in the binary.

gron/main.go

Lines 47 to 49 in 13561bd

// gronVersion stores the current gron version, set at build
// time with the ldflags -X option
var gronVersion = "dev"

Closes #97

@rperce
Copy link

rperce commented Jun 29, 2022

@tomnomnom wanted to bring this one to your attention, if you missed it—it closes the bothersome (to me) #97 and should be pretty straightforward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.7.1 does not report its own version
2 participants