feat: Add terminal completion for the Bash shell #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, i forgot the screenshot that shows it working: |
scop
reviewed
Nov 6, 2023
| # You can run the command: $ mv ./gron.bash ~/.bash_completion | ||
|
|
||
| function _gron_completion { | ||
| local AVAILABLE_COMMANDS="-c --colorize -j --json -k --insecure -m --monochrome -s --stream -u --ungron --no-sort --version" |
There was a problem hiding this comment.
I'd suggest removing the short options from this list. They are unlikely to be helpful -- if one remembers a short option, one can just type it; if one does not remember, displaying a list of short options is rarely helpful, but rather adds just noise.
FWIW this is the way we do things in bash-completion, guideline from there has some more elaboration/different words, https://github.com/scop/bash-completion/blob/master/CONTRIBUTING.md?plain=1#L136-L149
There was a problem hiding this comment.
(I'd suggest moving towards #116 instead of manually maintaining completions separately though.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112 Adding Bash completions