Feat/required features #324
Open
+788
−1,648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error code for missing features
…lets in mobile connection modal
mois-ilya
force-pushed
the
feat/required-features
branch
from
5e3e523 to
58619ce
Compare
mois-ilya
commented
Mar 6, 2025
| @@ -209,9 +200,9 @@ export class WalletsListManager { | |||
|
|
|||
| if (sseBridge) { | |||
| if ( | |||
| !('url' in sseBridge) || | |||
| !(sseBridge && typeof sseBridge === 'object' && 'url' in sseBridge) || | |||
mois-ilya
commented
Mar 6, 2025
| @@ -1,6 +1,10 @@ | |||
| import type { Property } from 'csstype'; | |||
| type Color = Property.Color; | |||
|
|
|||
| type DeepPartial<T> = { | |||
mois-ilya
commented
Mar 6, 2025
| @@ -220,7 +211,11 @@ export class WalletsListManager { | |||
| const jsBridge = bridge.find(item => (item as { type: string }).type === 'js'); | |||
|
|
|||
| if (jsBridge) { | |||
| if (!('key' in jsBridge) || !(jsBridge as { key: string }).key) { | |||
| if ( | |||
| typeof jsBridge !== 'object' || | |||
mois-ilya
commented
Mar 6, 2025
| @@ -18,6 +18,7 @@ export interface ConnectEventError { | |||
| payload: { | |||
| code: CONNECT_EVENT_ERROR_CODES; | |||
| message: string; | |||
| device?: DeviceInfo; | |||
mois-ilya
commented
Mar 6, 2025
| extraCurrencyRequired?: boolean; | ||
| }; | ||
|
|
||
| export type RequireSignDataFeature = { |
mois-ilya
commented
Mar 6, 2025
| }; | ||
|
|
||
| class ConnectErrorsParser { | ||
| parseError(error: ConnectEventError['payload']): TonConnectError { | ||
| let ErrorConstructor: typeof TonConnectError = UnknownError; |
mois-ilya
commented
Mar 6, 2025
| /** | ||
| * Thrown when wallet can't get manifest by passed manifestUrl. | ||
| */ | ||
| export class MissingRequiredFeaturesError extends TonConnectError { |
There was a problem hiding this comment.
Maybe need use generic for device
mois-ilya
commented
Mar 6, 2025
| @@ -35,6 +37,8 @@ export interface TonConnectOptions { | |||
| */ | |||
| walletsListCacheTTLMs?: number; | |||
|
|
|||
| walletsRequiredFeatures?: RequireFeature[] | ((features: Feature[]) => boolean); | |||
mois-ilya
commented
Mar 6, 2025
| /** | ||
| * Indicates if the wallet supports required features. | ||
| */ | ||
| isSupportRequiredFeatures: boolean; |
There was a problem hiding this comment.
Check in UIWalletList, for injected wallets
mois-ilya
commented
Mar 6, 2025
| <WalletsContainerStyled> | ||
| <For each={props.walletsList.slice(0, 3)}> | ||
| <For each={visibleWallets()}> |
There was a problem hiding this comment.
Add case than visibleWallets().length === 0
mois-ilya
commented
Mar 6, 2025
| @@ -26,6 +27,11 @@ export interface TonConnectUiOptions { | |||
| */ | |||
| walletsListConfiguration?: WalletsListConfiguration; | |||
|
|
|||
| /** | |||
| * TODO: add description | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.