Feature/training impl #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 19 changed files in this pull request and generated 1 suggestion.
Files not reviewed (14)
- src/toniarts/openkeeper/game/controller/creature/CreatureController.java: Evaluated as low risk
- src/toniarts/openkeeper/game/component/TaskComponent.java: Evaluated as low risk
- src/toniarts/openkeeper/game/controller/room/TrainingRoomController.java: Evaluated as low risk
- src/toniarts/openkeeper/game/logic/CreatureExperienceSystem.java: Evaluated as low risk
- src/toniarts/openkeeper/game/logic/CreatureViewSystem.java: Evaluated as low risk
- src/toniarts/openkeeper/game/controller/GameController.java: Evaluated as low risk
- src/toniarts/openkeeper/game/state/MainMenuScreenController.java: Evaluated as low risk
- src/toniarts/openkeeper/game/task/worker/DigTileTask.java: Evaluated as low risk
- src/toniarts/openkeeper/utils/WorldUtils.java: Evaluated as low risk
- src/toniarts/openkeeper/view/text/CreatureTextParser.java: Evaluated as low risk
- src/toniarts/openkeeper/game/controller/room/AbstractRoomController.java: Evaluated as low risk
- src/toniarts/openkeeper/game/task/TaskType.java: Evaluated as low risk
- src/toniarts/openkeeper/game/controller/RoomControllerFactory.java: Evaluated as low risk
- src/toniarts/openkeeper/game/task/creature/Train.java: Evaluated as low risk
Comments skipped due to low confidence (1)
src/toniarts/openkeeper/game/task/AbstractTask.java:168
- Ensure that the method is covered by tests, especially the case where no accessible target is found.
protected Vector2f getAccessibleTargetNextToLocation(ICreatureController creature) {
| * @param creature the creature trying to reach this | ||
| * @return task location next to the wanted tile | ||
| */ | ||
| protected Vector2f getAccessibleTargetNextToLocation(ICreatureController creature) { |
There was a problem hiding this comment.
The nested loop in this method is redundant and could lead to performance issues. Additionally, the method does not handle the case where no accessible target is found, returning null without any indication of failure.
Suggested change
| protected Vector2f getAccessibleTargetNextToLocation(ICreatureController creature) { | |
| protected Optional<Vector2f> getAccessibleTargetNextToLocation(ICreatureController creature) { |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creatures to train...
There is kinda duplicate time keeping for the training... It all kinda works. Task keeps check of validity and subtracts the money. ExperienceSystem then just deals with leveling the creature. Magically these systems are in sync as everything is executed sequentially. Not perhaps ideal but it conforms to our current design maybe the best...