enable GL debug names for RenderDoc #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (2)
src/toniarts/openkeeper/Main.java:336
- Ensure that the renderer object is an instance of GLRenderer before casting to avoid ClassCastException.
((GLRenderer)renderer).setDebugEnabled(true);
src/toniarts/openkeeper/Main.java:335
- Verify that the 'debug' variable is defined and properly initialized before use.
if (debug)
| @@ -203,6 +204,8 @@ public ModelViewer() { | |||
| @Override | |||
| public void simpleInitApp() { | |||
|
|
|||
| ((GLRenderer)renderer).setDebugEnabled(true); // get debug names for GL objects | |||
There was a problem hiding this comment.
Ensure that 'renderer' is an instance of 'GLRenderer' before casting. This cast can cause a ClassCastException if 'renderer' is not a 'GLRenderer'.
Suggested change
| ((GLRenderer)renderer).setDebugEnabled(true); // get debug names for GL objects | |
| if (renderer instanceof GLRenderer) { ((GLRenderer)renderer).setDebugEnabled(true); } |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
They only have 1 renderer implementation 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is normally enabled via
isGraphicsDebug: https://github.com/jMonkeyEngine/jmonkeyengine/blob/3ab36478ec59b7f8d6af271ca11ab26100df00ad/jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglContext.java#L250%USERHOME\.OpenKeeper\openkeeper.propertieshttps://github.com/search?q=repo%3AjMonkeyEngine/jmonkeyengine%20isGraphicsDebug&type=code
But that setting also enables checking of all GL calls and there are errors on some drivers which prevent it from starting:
jMonkeyEngine/jmonkeyengine#1996