Skip to content

Commit

Permalink
Debugging client metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
helder-junior committed Aug 13, 2024
1 parent a3ff77c commit 846260c
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 16 deletions.
3 changes: 2 additions & 1 deletion client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,9 @@ func (c *Client) newGRPCClient(
"serverAddress": c.serverAddress,
"async": async,
})

c.logger.Infoln("Registering events gateway metrics...")
err := metrics.RegisterMetrics(configPrefix, c.config)
c.logger.Infoln("Events gateway metrics registered.")
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion config/local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ client:
timeout: 500ms
loadtestclient:
duration: 10s
threads: 10
threads: 1
randSleepCeilingMs: 500
randPropsSize: small # small, medium, large, jumbo
prometheus:
Expand Down
28 changes: 15 additions & 13 deletions metrics/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
package metrics

import (
"errors"
"github.com/prometheus/client_golang/prometheus"
"github.com/spf13/viper"
)
Expand Down Expand Up @@ -81,22 +80,25 @@ var (
// it only returns an error if the metric wasn't already registered and there was an
// actual error registering it.
func RegisterMetrics(configPrefix string, config *viper.Viper) error {
collectors := []prometheus.Collector{

//collectors := []prometheus.Collector{
//
//}
prometheus.MustRegister(
ClientRequestsResponseTime,
ClientRequestsSuccessCounter,
ClientRequestsFailureCounter,
AsyncClientRequestsDroppedCounter,
}
AsyncClientRequestsDroppedCounter)

for _, collector := range collectors {
err := prometheus.Register(collector)
if err != nil {
var alreadyRegisteredError prometheus.AlreadyRegisteredError
if !errors.As(err, &alreadyRegisteredError) {
return err
}
}
}
//for _, collector := range collectors {
// err := prometheus.MustRegister()
// if err != nil {
// var alreadyRegisteredError prometheus.AlreadyRegisteredError
// if !errors.As(err, &alreadyRegisteredError) {
// return err
// }
// }
//}

return nil
}
2 changes: 1 addition & 1 deletion server/config/local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ pprof:
enabled: true
address: localhost:6060
otlp:
enabled: true
enabled: false
serviceName: "eventsgateway-server"
traceSamplingRatio: 0.2
jaegerHost: jaeger
Expand Down

0 comments on commit 846260c

Please sign in to comment.