Skip to content

Commit

Permalink
Remove unecessary traces from Server
Browse files Browse the repository at this point in the history
  • Loading branch information
helder-junior committed Aug 6, 2024
1 parent f8601a2 commit 9275ed3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
3 changes: 0 additions & 3 deletions server/app/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
"github.com/topfreegames/eventsgateway/v4/server/logger"
"github.com/topfreegames/eventsgateway/v4/server/sender"
pb "github.com/topfreegames/protos/eventsgateway/grpc/generated"
"go.opentelemetry.io/otel"
)

// Server struct
Expand All @@ -49,8 +48,6 @@ func (s *Server) SendEvent(
ctx context.Context,
req *pb.Event,
) (*pb.SendEventResponse, error) {
_, span := otel.Tracer("app.server").Start(ctx, "app.server.SendEvent")
defer span.End()
if err := s.sender.SendEvent(ctx, req); err != nil {
return nil, err
}
Expand Down
2 changes: 2 additions & 0 deletions server/forwarder/kafka.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"github.com/IBM/sarama"
"github.com/spf13/viper"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"log"
"os"
"strings"
Expand Down Expand Up @@ -57,6 +58,7 @@ func NewKafkaForwarder(config *viper.Viper) (*KafkaForwarder, error) {

func (k KafkaForwarder) Produce(ctx context.Context, topic string, message []byte) (int32, int64, error) {
_, span := otel.Tracer("forwarder.kafka").Start(ctx, "forwarder.kafka.Produce")
span.SetAttributes(attribute.Key("kafkaTopic").String(topic))
defer span.End()

prefixedTopic := fmt.Sprintf("%s%s", k.topicPrefix, topic)
Expand Down
6 changes: 0 additions & 6 deletions server/sender/kafka.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ package sender
import (
"bytes"
"context"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/attribute"
"sync"
"time"

Expand Down Expand Up @@ -69,9 +67,6 @@ func (k *KafkaSender) SendEvent(
ctx context.Context,
event *pb.Event,
) error {
_, span := otel.Tracer("sender.kafka").Start(ctx, "sender.kafka.SendEvent")
defer span.End()

l := k.logger.WithFields(map[string]interface{}{
"topic": event.GetTopic(),
"event": event,
Expand Down Expand Up @@ -108,7 +103,6 @@ func (k *KafkaSender) SendEvent(
}

topic := event.GetTopic()
span.SetAttributes(attribute.Key("kafkaTopic").String(topic))

partition, offset, err := k.producer.Produce(ctx, topic, buf.Bytes())

Expand Down

0 comments on commit 9275ed3

Please sign in to comment.