Change metrics Subsystem name to avoid conflicts with older metrics

client/client.go

@@ -113,9 +113,7 @@ func (c *Client) newGRPCClient(
 		"serverAddress": c.serverAddress,
 		"async":         async,
 	})
-	c.logger.Infoln("Registering events gateway metrics...")
 	err := metrics.RegisterMetrics(configPrefix, c.config)
-	c.logger.Infoln("Events gateway metrics registered.")
 	if err != nil {
 		return nil, err
 	}

client/sync.go

@@ -132,11 +132,6 @@ func (s *gRPCClientSync) metricsReporterInterceptor(
 		event.Topic,
 		"0",
 	).Inc()
-	metrics.HelderRequestsSuccessCounter.WithLabelValues(
-		method,
-		event.Topic,
-		"0",
-	).Inc()
 	return nil
 }
 

metrics/metrics.go

@@ -30,7 +30,7 @@ import (
 )
 
 const metricsNamespace = "eventsgateway"
-const metricsSubsystem = "client"
+const metricsSubsystem = "client_v4"
 
 var (
 
@@ -55,15 +55,6 @@ var (
 	},
 		[]string{"route", "topic", "retry"},
 	)
-	// HelderRequestsSuccessCounter is the count of successfull calls to the server
-	HelderRequestsSuccessCounter = prometheus.NewCounterVec(prometheus.CounterOpts{
-		Namespace: metricsNamespace,
-		Subsystem: metricsSubsystem,
-		Name:      "helder_requests_success_counter",
-		Help:      "the count of successfull client requests to the server",
-	},
-		[]string{"route", "topic", "retry"},
-	)
 
 	// ClientRequestsFailureCounter is the count of failed calls to the server
 	ClientRequestsFailureCounter = prometheus.NewCounterVec(prometheus.CounterOpts{
@@ -97,7 +88,6 @@ func RegisterMetrics(configPrefix string, config *viper.Viper) error {
 		ClientRequestsSuccessCounter,
 		ClientRequestsFailureCounter,
 		AsyncClientRequestsDroppedCounter,
-		HelderRequestsSuccessCounter,
 	}
 
 	for _, collector := range collectors {