Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from legacy gcm to Firebase #52

Merged
merged 26 commits into from
Apr 2, 2024
Merged

Conversation

miguelreiswildlife
Copy link
Collaborator

@miguelreiswildlife miguelreiswildlife commented Mar 22, 2024

Main changes done:

  • Create a PushClient interface that makes more sense than the old GCMClient interface
    • Implemention of the interface uses firebase SDK
  • Created a new implementation for MessageHandler
    • Created a new one instead adding a new client to the current one because firebase works very diferently in comparison to GCM.
  • When the MessageHandlers map is instatiated, it will use the new if there are firebase credentials for the game in question
    • Otherwise it will let the GCMMessageHandler instantiate the client as was done before
  • Firebase does not return the response of pushes async, but I tried to generate the same feedback and reports as done in the old handler

Makefile Show resolved Hide resolved
@miguelreiswildlife miguelreiswildlife merged commit 6b8de27 into master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants