Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): add optional ingored_prefixes to ignore multiple tags #667

Conversation

markkovari
Copy link

@markkovari markkovari commented Jan 26, 2024

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

My use case - sorry for not creating an issue for that - is that I am using rancher desktop as k8s/docker solution. And I wanted to ignore multiple paths with a prefix.

I am not really sure if this is a huge impact, in my case it was 8-10 tags to ignore, but might be helpful for others. Tagging @JakobFels, since he did the previous container related one; what is your take here? Should we rather ignore things one by one or should we be able to skip with prefix?

At the same time the config options merging strategy might be totally incorrect, can anyone help me out with that part?

@markkovari
Copy link
Author

It was literally parallelly developed in #666 today. Great work @SteveLauC .

@markkovari markkovari closed this Jan 26, 2024
@markkovari markkovari deleted the feat/ignore-containers-with-prefix branch January 26, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant