Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module installer guide about META-INF #8631

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

aviraxp
Copy link
Contributor

@aviraxp aviraxp commented Dec 13, 2024

This syncs with FlashModule behavior.

Copy link
Collaborator

@vvb2060 vvb2060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either delete all or keep all.

@aviraxp aviraxp changed the title Don't overwrite updater-script in DownloadEngine Update module installer guide about META-INF Dec 15, 2024
@aviraxp
Copy link
Contributor Author

aviraxp commented Dec 15, 2024

Keep it now as-is to avoid breaking module itself's verifying scripts.

@aviraxp aviraxp requested a review from vvb2060 December 15, 2024 04:46
@topjohnwu topjohnwu merged commit dadba44 into topjohnwu:master Dec 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants