Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #175

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve logging #175

wants to merge 7 commits into from

Conversation

gregemax
Copy link

added object flexible logging utility that adapts to both browser and CLI environments, ensuring consistent logging functionality across platforms.](#172)

@d-roak
Copy link
Member

d-roak commented Sep 26, 2024

Hey!
The objects are printed but not expandable. That was the reason why #102 was reverted.

If this is a work in progress mark the PR as a draft. Ping me when you want the next review, this is the third time I've reviewed this issue and it didn't fix the issues mentioned before in all instances. Be aware that doing a feature/code review also takes effort and time. If the next revision, keeps not fixing the core issues mentioned in the past, I'm going to unassign the task. The suggestion here would be for you to manually test every problem i mentioned before, posting some screenshots of the solution and review your code before asking for the review

In order for us to not both waste too much time, if you have any questions on approaches or clarity of the problems descriptions, contact us in the official tg or discord

@gregemax
Copy link
Author

consider a logger like winston or pino with browser-specific handling plugins for more control over object logging and nested data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants