Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the rubocop group across 1 directory with 3 updates #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2024

Updates the requirements on rubocop, rubocop-rails and rubocop-rspec to permit the latest version.
Updates rubocop to 1.66.1

Release notes

Sourced from rubocop's releases.

RuboCop 1.66.1

Bug fixes

  • #13191: Fix an error for Style/IfWithSemicolon when using nested single-line if/;/end in block of if/else branches. (@​koic)
  • #13178: Fix false positive for Style/EmptyLiteral with Hash.new([]). (@​earlopain)
  • #13176: Fix crash in Style/EmptyElse when AllowComments: true and the else clause is missing. (@​vlad-pisanov)
  • #13185: Fix false negatives in Style/MapIntoArray autocorrection when using ensure, def, defs and for. (@​vlad-pisanov)
Changelog

Sourced from rubocop's changelog.

1.66.1 (2024-09-04)

Bug fixes

  • #13191: Fix an error for Style/IfWithSemicolon when using nested single-line if/;/end in block of if/else branches. ([@​koic][])
  • #13178: Fix false positive for Style/EmptyLiteral with Hash.new([]). ([@​earlopain][])
  • #13176: Fix crash in Style/EmptyElse when AllowComments: true and the else clause is missing. ([@​vlad-pisanov][])
  • #13185: Fix false negatives in Style/MapIntoArray autocorrection when using ensure, def, defs and for. ([@​vlad-pisanov][])

1.66.0 (2024-08-31)

New features

  • #13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. ([@​earlopain][])
  • #13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. ([@​earlopain][])
  • #13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. ([@​zopolis4][])
  • #13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. ([@​earlopain][])

Bug fixes

  • #13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. ([@​koic][])
  • #13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. ([@​koic][])
  • #13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. ([@​koic][])
  • #13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. ([@​koic][])
  • #13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. ([@​koic][])
  • #13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. ([@​koic][])
  • #13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. ([@​koic][])
  • #13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. ([@​koic][])
  • #13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. ([@​koic][])
  • #13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). ([@​koic][])
  • #13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. ([@​fatkodima][])
  • #13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. ([@​koic][])
  • #13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. ([@​koic][])
  • #13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. ([@​earlopain][])
  • #13137: Fix an error for Style/ParallelAssignment when using __FILE__. ([@​earlopain][])
  • #13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. ([@​earlopain][])
  • #13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. ([@​vlad-pisanov][])
  • #13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). ([@​vlad-pisanov][])
  • #13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). ([@​vlad-pisanov][])
  • #13126: Fix a false positive for Style/Alias when using multiple alias in def. ([@​koic][])
  • #13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. ([@​koic][])
  • #13118: Fix a false positive for Style/MapIntoArray when splatting. ([@​earlopain][])
  • #13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. ([@​koic][])
  • #13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. ([@​koic][])
  • #13134: Fix false negative for Lint/Void when using using frozen literals. ([@​vlad-pisanov][])
  • #13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. ([@​koic][])
  • #13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. ([@​earlopain][])
  • #13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. ([@​earlopain][])
  • #13155: Fixes an error when the server cache directory has too long path, causing rubocop to fail even with caching disabled. ([@​protocol7][])

... (truncated)

Commits
  • ba8e7be Cut 1.66.1
  • 2900c91 Update Changelog
  • 08bed81 Fix an error for Style/IfWithSemicolon
  • c2ae362 Don't parse YAML twice
  • 5f3481f Use rubocop-ast SimpleForwardable
  • 5e65a39 Merge pull request #13185 from vlad-pisanov/vp_map_into_array_2
  • d18b3c9 Fix false negatives in Style/MapIntoArray autocorrection when using `ensure...
  • 3277118 [Fix #13182] Tweak the doc for Style/RedundantInterpolationUnfreeze
  • 9a38b11 Merge pull request #13179 from Earlopain/node-matcher-directiry-error
  • fd4f4d7 Fix an error for InternalAffairs/NodeMatcherDirective when no second argument
  • Additional commits viewable in compare view

Updates rubocop-rails to 2.26.2

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.26.2

Bug fixes

  • #1362: Fix false positives for Rails/EnumSyntax when using Ruby 2.7. (@​koic)
  • #1269: Fix false positives for Rails/ActionControllerFlashBeforeRender in combination with implicit returns. (@​earlopain)
  • #1326: Fix wrong autocorrect for Rails/FilePath when passing an array to File.join. (@​earlopain)

Changes

Changelog

Sourced from rubocop-rails's changelog.

2.26.2 (2024-09-21)

Bug fixes

  • #1362: Fix false positives for Rails/EnumSyntax when using Ruby 2.7. ([@​koic][])
  • #1269: Fix false positives for Rails/ActionControllerFlashBeforeRender in combination with implicit returns. ([@​earlopain][])
  • #1326: Fix wrong autocorrect for Rails/FilePath when passing an array to File.join. ([@​earlopain][])

Changes

2.26.1 (2024-09-07)

Bug fixes

  • #1343: Fix false negatives for Rails/EnumSyntax for non-literal mappings. ([@​earlopain][])
  • #1340: Fix a false positive for Rails/WhereEquals, Rails/WhereNot, and Rails/WhereRange when qualifying the database name. ([@​earlopain][])

Changes

2.26.0 (2024-08-24)

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. ([@​earlopain][])
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. ([@​earlopain][])
  • #1337: Fix an error for Rails/Validation when passing no arguments. ([@​earlopain][])
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. ([@​earlopain][])
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. ([@​tldn0718][])
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. ([@​koic][])
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. ([@​earlopain][])
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. ([@​earlopain][])
  • #1302: Allow params receiver by default for Style/CollectionMethods. ([@​koic][])
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). ([@​earlopain][])

Changes

... (truncated)

Commits
  • f646d6e Cut 2.26.2
  • a451135 Update Changelog
  • f935a0b Suppress new RuboCop offenses
  • 4a00257 Merge pull request #1326 from Earlopain/wrong-autocorrect-for-rails-file-path
  • 38cec18 [Doc] Sync the Rails configuration tip with the README
  • 5dc42d5 Merge pull request #1363 from koic/fix_false_positives_for_rails_enum_syntax
  • 50fe9a7 [Fix #1362] Fix false positives for Rails/EnumSyntax
  • 210f42e Merge pull request #1344 from Earlopain/revert-1311
  • 5e66785 Merge pull request #1361 from masato-bkn/fix-rails-compact-blank
  • f4f3bf1 Fix Rails/CompactBlank to avoid reporting offense for filter in Ruby vers...
  • Additional commits viewable in compare view

Updates rubocop-rspec to 3.1.0

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v3.1.0

  • Add RSpec/StringAsInstanceDoubleConstant to check for and correct strings used as instance_doubles. (@​corsonknowles)
  • Fix false-positive for RSpec/UnspecifiedException when a method is literally named raise_exception. (@​aarestad)
  • Fix false-positive for RSpec/UnspecifiedException when not_to raise_error is used within a block. (@​aarestad, @​G-Rath)
Changelog

Sourced from rubocop-rspec's changelog.

3.1.0 (2024-10-01)

  • Add RSpec/StringAsInstanceDoubleConstant to check for and correct strings used as instance_doubles. ([@​corsonknowles])
  • Fix false-positive for RSpec/UnspecifiedException when a method is literally named raise_exception. ([@​aarestad])
  • Fix false-positive for RSpec/UnspecifiedException when not_to raise_error is used within a block. ([@​aarestad], [@​G-Rath])

3.0.5 (2024-09-07)

  • Fix false-negative and error for RSpec/MetadataStyle when non-literal args are used in metadata in EnforceStyle: hash. ([@​cbliard])
  • Improve offense message for RSpec/IndexedLet. ([@​earlopain])

3.0.4 (2024-08-05)

  • Fix false-negative for UnspecifiedException when matcher is chained. ([@​r7kamura])

3.0.3 (2024-07-12)

  • Add support for Unicode RIGHT SINGLE QUOTATION MARK in RSpec/ExampleWording. ([@​jdufresne])
  • Suppress deprecation warning for RSpec/MultipleExpectations, RSpec/MultipleMemoizedHelpers, and RSpec/NestedGroups cops. ([@​koic])

3.0.2 (2024-07-02)

  • Fix wrong autocorrect for RSpec/ScatteredSetup when hook contains heredoc. ([@​earlopain])
  • Fix false negative for RSpec/PredicateMatcher when expectation contains custom failure message. ([@​earlopain])
  • Facilitate the 3.0 upgrade flow with proper extracted cop messages. ([@​jeppester])

3.0.1 (2024-06-11)

  • Bump RuboCop requirement to +1.61. ([@​ydah])

3.0.0 (2024-06-11)

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. ([@​ydah])
  • Remove RuboCop::RSpec::Language::NodePattern. ([@​ydah])
  • Remove RSpec/FilePath cop. ([@​ydah])
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. ([@​ydah])
  • Add new RSpec/MissingExpectationTargetMethod cop. ([@​krororo])
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. ([@​earlopain])

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

2.31.0 (2024-06-07)

  • Support AutoCorrect: contextual option for LSP. ([@​ydah])

2.30.0 (2024-06-03)

... (truncated)

Commits
  • 5e06176 Merge pull request #1963 from rubocop/release
  • 34c042e Bump version to v3.1.0
  • dea7de9 Merge pull request #1957 from corsonknowles/master
  • 324552c Add RSpec/StringAsInstanceDoubleConstant
  • 5959ad6 Merge pull request #1962 from G-Rath/add-spec
  • 1f48c7b test: showcase RSpec/UnspecifiedException block/chain confusion is fixed
  • 79e0bf7 Merge pull request #1960 from aarestad/unspecified-exception-fix
  • a59315f fix false positive on UnspecifiedException cop when function is named raise_e...
  • cf0ac65 Merge pull request #1958 from rubocop/cop-config-order
  • 5b91d18 Merge pull request #1959 from rubocop/fix-RedundantSourceRange-offenses
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop), [rubocop-rails](https://github.com/rubocop/rubocop-rails) and [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) to permit the latest version.

Updates `rubocop` to 1.66.1
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.65.1...v1.66.1)

Updates `rubocop-rails` to 2.26.2
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.25.0...v2.26.2)

Updates `rubocop-rspec` to 3.1.0
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v3.0.1...v3.1.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  dependency-group: rubocop
- dependency-name: rubocop-rails
  dependency-type: direct:development
  dependency-group: rubocop
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  dependency-group: rubocop
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 1, 2024 21:25
@dependabot dependabot bot added dependencies Pull requests that update a dependency file DevX no-jira ruby WIP Work in Progress labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file DevX no-jira ruby WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants