Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor packages: extract announce and scrape services #1336

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Feb 28, 2025

Refactor packages: extract announce and scrape services.

HTTP

http-tracker-core package:

  • bittorrent_http_tracker_core::services::announce::handle_announce
  • bittorrent_http_tracker_core::services::scrape::handle_scrape

UDP

udp-tracker-core package:

  • bittorrent_udp_tracker_core::services::connect::handle_connect
  • bittorrent_udp_tracker_core::services::announce::handle_announce
  • bittorrent_udp_tracker_core::services::scrape::handle_scrape

@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Feb 28, 2025
@josecelano josecelano requested a review from da2ce7 February 28, 2025 11:19
@josecelano josecelano self-assigned this Feb 28, 2025
@josecelano josecelano marked this pull request as draft February 28, 2025 11:19
@josecelano josecelano force-pushed the 1326-refactor-packages-extract-announce-and-scrape-servicehandler-structs branch from a4d8f1e to 3e77b7f Compare February 28, 2025 11:21
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 96.92308% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.51%. Comparing base (809b85b) to head (ddb3381).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/container.rs 0.00% 7 Missing ⚠️
packages/udp-tracker-core/src/services/scrape.rs 89.28% 1 Missing and 2 partials ⚠️
...ackages/http-tracker-core/src/services/announce.rs 98.07% 1 Missing and 1 partial ⚠️
packages/udp-tracker-core/src/services/announce.rs 95.45% 0 Missing and 2 partials ⚠️
packages/http-tracker-core/src/services/scrape.rs 98.52% 0 Missing and 1 partial ⚠️
packages/udp-tracker-server/src/handlers/scrape.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1336      +/-   ##
===========================================
- Coverage    81.51%   81.51%   -0.01%     
===========================================
  Files          230      230              
  Lines        16368    16275      -93     
  Branches     16368    16275      -93     
===========================================
- Hits         13343    13267      -76     
+ Misses        2792     2776      -16     
+ Partials       233      232       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 1326-refactor-packages-extract-announce-and-scrape-servicehandler-structs branch from 3e77b7f to 9cda8ec Compare February 28, 2025 11:58
@josecelano josecelano marked this pull request as ready for review February 28, 2025 17:47
@josecelano
Copy link
Member Author

ACK ddb3381

@josecelano josecelano changed the title Refactor packages: extract announce and scrape service/handler structs Refactor packages: extract announce and scrape services Feb 28, 2025
@josecelano josecelano merged commit 77c8395 into torrust:develop Feb 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor packages: extract announce and scrape service/handler structs
1 participant