-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #125: contributor articles not appearing on contributor page
d4458bd fix check error (Graeme Byrne) 270b368 fix lint error (Graeme Byrne) 59b8ec9 contributor articles not appearing on contributor page (Graeme Byrne) Pull request description: * `routes/contributor/+layout.server.ts` wasn't accessing data from `routes/api` which had been set up to facilitate the change from `routes/(blog)` to `routes/blog`. This was causing the contributor's articles not to be shown on their page as detailed [here](#123). I made this data accesible to `routes/contributor` by adding the code below to `routes/contributor/+layout.server.ts` ``` export const load = async ({ fetch }) => { const response = await fetch(`/api`); const posts = await response.json(); return { posts }; }; ``` * Replaced deprecated [Shijiki](https://github.com/antfu/shikiji) and [shiki-es](https://github.com/pi0/shiki-es) with [Shiki](https://github.com/shikijs/shiki) as mentioned [here](#76). ACKs for top commit: josecelano: ACK d4458bd Tree-SHA512: 5d2a6b089827349489e3cb944a49ee6258d12c834e2af3e007e36150ba97f8ab82b49ee19fd7756cc1dae9a52104247c0630470ee85c1ceacb29affd242bd963
- Loading branch information
Showing
12 changed files
with
465 additions
and
85 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -354,7 +354,7 @@ | |
padding-top: 2rem; | ||
} | ||
#toc-builder-preview > h2 { | ||
h2 { | ||
font-size: 1.8rem; | ||
font-weight: bold; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
import { filteredPosts } from '$lib/data/blog-posts'; | ||
export const load = async ({ fetch }) => { | ||
const response = await fetch(`/api`); | ||
const posts = await response.json(); | ||
|
||
export async function load() { | ||
return { | ||
posts: filteredPosts | ||
posts | ||
}; | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,18 @@ | ||
<slot /> | ||
<div class="contributors"> | ||
<h1>Contributors</h1> | ||
<slot /> | ||
</div> | ||
|
||
<style lang="scss"> | ||
.contributors { | ||
background: rgba(26, 26, 26, 1); | ||
padding-block: 2rem; | ||
} | ||
h1 { | ||
font-size: 2.5rem; | ||
padding-block: 3rem; | ||
text-align: center; | ||
color: rgba(245, 245, 245, 0.96); | ||
} | ||
</style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters