Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to the Event View and class naming #1168

Closed
wants to merge 11 commits into from
Closed

Conversation

marksie1988
Copy link
Collaborator

@marksie1988 marksie1988 commented Sep 23, 2023

Proposed Change

This change implements a new format for the event mode, previously this mode used a table with divs inside, this meant that customising the style was somewhat limited due to the table.

Moving to a full div based design with classes on all of the divs enables much more customisation utilising card mod.

There are multiple changes here that will likely break existing card mods and also remove some font/color config options from ACR as these can be customised with card mod now.

Class changes

headerNameSuperCompact class replaced with header-name compact
headerName class renamed to header-name
headerDateSuporCompact class replaced with header-date compact
headerDate class renamed to header-date
hoursHTML class renamed to hours
relativeTime class renamed to relative-time
timeRemaining class renamed to time-remaining
event-leftCurrentDay class renamed to current-day
hide-date class added when showEventDate: false
added classes event-date-day, event-date-month, event-date-week-day for left column dates.
event-leftSuperCompact class replaced with event-left compact
event-titleRunning class replaced with event-title running
eventIcon class renamed to event-icon

Config Removed

dateColor
dateSize
dayWrapperLineColor
eventTitleSize
timeColor
timeSize

Related issues

fixes #1160
fixes #1154
fixes #1147

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (build / ci etc.)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@marksie1988 marksie1988 changed the title feat!: event mode style and class changes Enhancements to the Event View and class naming Sep 24, 2023
@marksie1988 marksie1988 deleted the develop branch September 26, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants