Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HOST_IP in favor of host-gateway #301

Closed
wants to merge 1 commit into from
Closed

Remove HOST_IP in favor of host-gateway #301

wants to merge 1 commit into from

Conversation

markmetcalfe
Copy link
Member

@markmetcalfe markmetcalfe commented Nov 25, 2024 •
edited
Loading

Implementation of the fix @codyfinegan mentioned in #8

TODO: Need to properly test that this works across both Mac and Linux

@markmetcalfe markmetcalfe force-pushed the use-host-gateway branch 4 times, most recently from 168903c to f3a6ced Compare November 25, 2024 22:11
@markmetcalfe markmetcalfe changed the base branch from master to develop November 25, 2024 22:11
@AaronMachin
Copy link

Ah I've tested this on a linux VM and it doesn't resolve to the host. Probably a useful variable to keep, at least for the time being.

@markmetcalfe
Copy link
Member Author

Ah I've tested this on a linux VM and it doesn't resolve to the host. Probably a useful variable to keep, at least for the time being.

@AaronMachin That was happening after tupping the php-debug container(s) again?

@scq
Copy link
Member

scq commented Nov 25, 2024

Working for me inside WSL2. Connecting to XDebug works, and I can use the host.docker.internal hostname from inside the container:

> tzsh php-8.3-debug
> curl host.docker.internal                               
<html>
<head><title>Index of /</title></head>
<body>
...

@AaronMachin
Copy link

@markmetcalfe ah yep it's working - just a weird issue with my vm setup. However, I do actively use this variable to achieve my VM setup. If it was removed I would have to set this up manually

@markmetcalfe markmetcalfe marked this pull request as ready for review November 25, 2024 22:30
@AaronMachin AaronMachin requested review from AaronMachin and removed request for AaronMachin November 25, 2024 22:36
@AaronMachin
Copy link

No idea how to approve on here haha! Happy with the changes

@markmetcalfe markmetcalfe marked this pull request as draft November 25, 2024 22:38
@markmetcalfe
Copy link
Member Author

Just going to double check something on Mac - putting back into draft

@markmetcalfe
Copy link
Member Author

Hmm I've had inconsistent results getting this to work on Mac - I think there still isn't really a good solution that supports all OSes at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scq scq scq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmetcalfe @AaronMachin @scq