Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read_line to raise EOFError if nothing was read #86

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Fix read_line to raise EOFError if nothing was read #86

merged 3 commits into from
Jul 6, 2023

Conversation

sk1p
Copy link
Contributor

@sk1p sk1p commented Jul 6, 2023

Fixes #69. Explicitly raises an EOFError to differentiate empty-line and EOF cases. Also, os.read returns a byte string of length 0 in case of EOF, so the except branch probably was never hit.

gaborbernat
gaborbernat approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit fadd91b into tox-dev:main Jul 6, 2023
25 checks passed
@sk1p sk1p deleted the bugfix-linger-backend branch July 6, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lingering _backend.py process
2 participants
@sk1p @gaborbernat