default port tcp

[chayim]

closes issue #98

[jugmac00]

Please have a look at the broken test suite.

[jugmac00]

I removed myself as a reviewer as I neither use nor maintain this package. I just commented on the broken build to speed up the review process for the core maintainers.

broken build has been fixed

[gaborbernat]

We should also add some tests 👍

[gaborbernat]

typo here

[dcrosta]

I'm leaning towards not accepting this -- the inconvenience of having to type "tcp:" seems a small and infrequent price to pay for greater explicitness in the tox-docker config. Does anyone feel really strongly about this?

[chayim]

Doing this is aligns tox-docker more closelt with docker. My bias is to standardize on the behaviour of the tool with which I'm integrating. I expected tox-docker to require port declarations to match the docker syntax, it helps reduce the barrier to entry.

…

On Mon., May 24, 2021, 21:47 Dan Crosta, ***@***.***> wrote: I'm leaning towards not accepting this -- the inconvenience of having to type "tcp:" seems a small and infrequent price to pay for greater explicitness in the tox-docker config. Does anyone feel really strongly about this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#99 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKFVRTQPMRAWLQSCVT6EXTTPKNLXANCNFSM45GSZCWQ> .

[gaborbernat]

I'm personally leaning towards @chayim here, but not strongly. Also note the main maintainer here is @dcrosta so ultimately it's up to his decision.

[chayim]

We should also add some tests

@gaborbernat Happy to add the tests and finish this off. But if @dcrosta doesn't want this behaviour then we should kill it off.

[chayim]

Ping @dcrosta do you have a preference - prior to my writing the tests?

[chayim]

Given the lack of answer - I assume we don't want this. Closing.