[FIX] TOML set_env from file
#3478
Conversation
|
|
||
| def replacer(raw_: str, args_: ConfigLoadArgs) -> str: | ||
| if conf is None: | ||
| replaced = raw_ # no replacement supported in the core section |
There was a problem hiding this comment.
TBH this condition I've just taken from the INI correspondant... Pls double-check if it makes sense in TOML parsing context. Thanks.
juditnovak
force-pushed
the
fix/toml_setenv_from_file
branch
from
ab08b87 to
30ad161
Compare
juditnovak
force-pushed
the
fix/toml_setenv_from_file
branch
from
10c8e9c to
7dc1f78
Compare
juditnovak
changed the title
set_env from fileset_env from file
| ("conf_type", "config"), | ||
| [ | ||
| ("ini", "[testenv]\npackage=skip\nset_env=file|A{/}a.txt\nchange_dir=C"), | ||
| ("toml", '[env_run_base]\npackage="skip"\nset_env="file|A{/}a.txt"\nchange_dir="C"'), |
There was a problem hiding this comment.
It would make more sense that this to be a dictionary key rather than we just unroll a string. Something like 'set_env = [ { file= "a.txt"}] `.
There was a problem hiding this comment.
Just to make sure that I'm following correctly. Could you pls confirm that the following is what you suggest?
INI:
The current syntax supported for tox.ini for set_env:
[testenv]
set_env=file|<path>
TOML:
Moving away from the file| syntax introduced for tox.ini, benefitting from embedded data structures instead such as:
[env_run_base]
set_env=[{file=<path>}]
While this would raise an ERROR in TOML:
[env_run_base]
set_env="file|<path>"
Is this the direction you would like to take? Not to support file| terminology when TOML configuration is used?
(Sorry, I understood that a PR was welcome for the issue as raised -- which my attempt was aiming to respond. Of course, I'm glad to modify the code alongside a different design, if preferred. I agree that the above solution is more elegant.)
There was a problem hiding this comment.
Yeah, with the TOML format we generally are trying to move away from embedding information into strings, and instead use the rich type system and structure of the TOML language instead.
|
You still plan to tackle this? |
This code change is addressing #3474, making sure that TOML config has the same support to apply
set_envfrom file, as INI configuration does.