自分の投稿の通知に含めるかの設定するapiの実装 #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribe1115
reviewed
Jun 18, 2023
Comment on lines
+18
to
+25
| err := db.Select(&wordMe, "SELECT me_notification, word FROM words WHERE word = ? AND trap_id = ?", word, userId) | ||
| if errors.Is(err, sql.ErrNoRows) { | ||
| slog.Info("No Data Found") | ||
| return err | ||
| } else if err != nil { | ||
| slog.Info("Error: %s", err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
ここの存在確認、model.ExistWordを事前にhandler側の関数で呼び出してやるのがいいんじゃない？
There was a problem hiding this comment.
そもそもdb.Selectを使うとsql.ErrNoRowsは返ってこないです
Comment on lines
+26
to
+29
| if len(wordMe) != 1 { | ||
| slog.Info("Already exist too many data same trap_id and word: %d", len(wordMe)) | ||
| return fmt.Errorf("Already exist too many data same trap_id and word: %d", len(wordMe)) | ||
| } |
There was a problem hiding this comment.
model.ExistWordを使えばこの考慮はいらないはず
Comment on lines
+39
to
+46
| err := db.Select(&wordMes, "SELECT me_notification, word FROM words WHERE trap_id = ?", userId) | ||
| if errors.Is(err, sql.ErrNoRows) { | ||
| slog.Info("No Data Found") | ||
| return err | ||
| } else if err != nil { | ||
| slog.Info("Error: %s", err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
一括全件更新のときはこのチェックなしでupdateかけていい
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUT /words/me/POST /words/me/allpostmanで確認済み