Revert "Added max device speed attribute"

This reverts commit e9ac536.

src/common/attributes/useCommonUserAttributes.js

@@ -145,8 +145,4 @@ export default (t) => useMemo(() => ({
     name: t('attributeNavigationAppTitle'),
     type: 'string',
   },
-  'ui.MaxExpectedDeviceSpeed': {
-    name: t('attributeUIMaxExpectedDeviceSpeed'),
-    type: 'number',
-  },
 }), [t]);

src/map/MapRoutePath.js

@@ -1,15 +1,13 @@
 import { useTheme } from '@mui/styles';
-import { useId, useEffect, useMemo } from 'react';
+import { useId, useEffect } from 'react';
 import { useSelector } from 'react-redux';
 import { map } from './core/MapView';
 import getSpeedColor from '../common/util/colors';
-import { useAttributePreference } from '../common/util/preferences';
 
 const MapRoutePath = ({ positions }) => {
   const id = useId();
-  const theme = useTheme();
 
-  const MaxExpectedDeviceSpeed = useAttributePreference('ui.MaxExpectedDeviceSpeed');
+  const theme = useTheme();
 
   const reportColor = useSelector((state) => {
     const position = positions?.find(() => true);
@@ -25,13 +23,6 @@ const MapRoutePath = ({ positions }) => {
     return null;
   });
 
-  const maxSpeed = useMemo(() => {
-    if (MaxExpectedDeviceSpeed > 0) {
-      return MaxExpectedDeviceSpeed;
-    }
-    return positions.map((item) => item.speed).reduce((a, b) => Math.max(a, b), -Infinity);
-  }, [MaxExpectedDeviceSpeed, positions]);
-
   useEffect(() => {
     map.addSource(id, {
       type: 'geojson',
@@ -71,6 +62,7 @@ const MapRoutePath = ({ positions }) => {
   }, []);
 
   useEffect(() => {
+    const maxSpeed = positions.map((item) => item.speed).reduce((a, b) => Math.max(a, b), -Infinity);
     const features = [];
     for (let i = 0; i < positions.length - 1; i += 1) {
       features.push({
@@ -91,7 +83,7 @@ const MapRoutePath = ({ positions }) => {
       type: 'FeatureCollection',
       features,
     });
-  }, [theme, positions, reportColor, maxSpeed, id]);
+  }, [theme, positions, reportColor]);
 
   return null;
 };

src/map/MapRoutePoints.js

@@ -1,13 +1,9 @@
-import {
-  useId, useCallback, useEffect, useMemo,
-} from 'react';
+import { useId, useCallback, useEffect } from 'react';
 import { map } from './core/MapView';
 import getSpeedColor from '../common/util/colors';
-import { useAttributePreference } from '../common/util/preferences';
 
 const MapRoutePoints = ({ positions, onClick }) => {
   const id = useId();
-  const MaxExpectedDeviceSpeed = useAttributePreference('ui.MaxExpectedDeviceSpeed');
 
   const onMouseEnter = () => map.getCanvas().style.cursor = 'pointer';
   const onMouseLeave = () => map.getCanvas().style.cursor = '';
@@ -20,13 +16,6 @@ const MapRoutePoints = ({ positions, onClick }) => {
     }
   }, [onClick]);
 
-  const maxSpeed = useMemo(() => {
-    if (MaxExpectedDeviceSpeed > 0) {
-      return MaxExpectedDeviceSpeed;
-    }
-    return positions.map((p) => p.speed).reduce((a, b) => Math.max(a, b), -Infinity);
-  }, [MaxExpectedDeviceSpeed, positions]);
-
   useEffect(() => {
     map.addSource(id, {
       type: 'geojson',
@@ -68,6 +57,7 @@ const MapRoutePoints = ({ positions, onClick }) => {
   }, [onMarkerClick]);
 
   useEffect(() => {
+    const maxSpeed = positions.map((p) => p.speed).reduce((a, b) => Math.max(a, b), -Infinity);
     map.getSource(id)?.setData({
       type: 'FeatureCollection',
       features: positions.map((position, index) => ({
@@ -84,7 +74,7 @@ const MapRoutePoints = ({ positions, onClick }) => {
         },
       })),
     });
-  }, [id, positions, maxSpeed]);
+  }, [onMarkerClick, positions]);
 
   return null;
 };

src/resources/l10n/en.json

@@ -612,6 +612,5 @@
     "categoryVan": "Van",
     "categoryScooter": "Scooter",
     "maintenanceStart": "Start",
-    "maintenancePeriod": "Period",
-    "attributeUIMaxExpectedDeviceSpeed": "Max Expected Device Speed"
+    "maintenancePeriod": "Period"
 }